Skip to content

Update Github Action #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Update Github Action #390

merged 1 commit into from
Feb 2, 2021

Conversation

joelachance
Copy link
Collaborator

Resolves #384.

Update Github Action to use the new chabad360/hugo-gh-pages version. This allows us to push the build to a different repository.

This hasn't been tested as it's set up for master.

… allows to be pushed to a separate repository.
@mattip
Copy link
Member

mattip commented Feb 2, 2021

It is hard to tell if all the bits are correct until we try it. But the risk is low: if the push to numpy/numpy.github.com fails, nothing will change.

@mattip
Copy link
Member

mattip commented Feb 2, 2021

(I cannot merge in this repo)

@rgommers rgommers merged commit 8be869c into master Feb 2, 2021
@rgommers rgommers deleted the feature/384-gh-actions branch February 2, 2021 08:18
@rgommers
Copy link
Member

rgommers commented Feb 2, 2021

Let's give it a try. Thanks @joelachance!

@rgommers
Copy link
Member

rgommers commented Feb 2, 2021

That GitHub Action wasn't used a lot, so I reviewed it in detail. Seems safe.

@rgommers
Copy link
Member

rgommers commented Feb 2, 2021

It failed with:

Unexpected input(s) 'hugoVersion', valid inputs are ['repository', 'ref', 'token', 'ssh-key', 'ssh-known-hosts', 'ssh-strict', 'persist-credentials', 'path', 'clean', 'fetch-depth', 'lfs', 'submodules']

@rgommers rgommers mentioned this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Github Actions to push build to numpy.github.com
3 participants